feat(tests): generate coverage reports for components - #142
Conversation
EnriqueParodi
left a comment
EnriqueParodi
left a comment
There was a problem hiding this comment.
Hi Manuel, can you please relay my feedback to the author?
The mechanism is good!
The problem is that sen_internal_configure_component also sets FOLDER "components", and in every component the call sits two lines after one that sets FOLDER "components/". The new call runs later and wins, so the IDE grouping flattens from components/ether, components/influx and so on into a single components folder.
73: set_target_properties(ether PROPERTIES FOLDER "components/ether")
75: sen_internal_configure_component(ether)
Same in explorer, influx, logmaster, py, recorder, replayer, rest and tracy. Shell differs slightly, its line at 47 is for terminal_lib.
Coverage only needs the set_property(GLOBAL APPEND ...) line. Either take the set_target_properties block out of the function, or keep it and delete the per-component FOLDER lines so the flattening is intended.
Thanks!
f23c14f to
5f0a992
Compare
662f7c9 to
9c21163
Compare
5f0a992 to
75de554
Compare
Coverage reporting covered the libraries only; component targets are now included in the generated report. Resolves SEN-1744
9c21163 to
ea5eb93
Compare
3 participants
Resolves SEN-1744