fix(shell): fix layout and labels in ls for empty sources - #141
Open
lolito93 wants to merge 1 commit into
Conversation
EnriqueParodi
requested changes
Aug 26, 2026
EnriqueParodi
left a comment
EnriqueParodi
left a comment
Collaborator
There was a problem hiding this comment.
Hi Manuel, can you please relay my feedback to the author?
The fix is right, and it explains the bug.
The PR removes a term_->newLine() from doOpen. Was this related to the bug?
Thanks!
EnriqueParodi
force-pushed
the
SEN-1768-fix-convergence-of-smooth-extrapolated-position
branch
from
August 27, 2026 10:33
860aa56 to
2a00044
Compare
EnriqueParodi
force-pushed
the
SEN-1777-bus-going-out-of-scope-creates-weird-behavior-in-shell
branch
from
August 27, 2026 10:33
f23c14f to
5f0a992
Compare
EnriqueParodi
marked this pull request as draft
August 27, 2026 14:28
EnriqueParodi
marked this pull request as ready for review
August 27, 2026 14:28
EnriqueParodi
changed the title
EnriqueParodi
marked this pull request as draft
August 27, 2026 15:14
EnriqueParodi
marked this pull request as ready for review
August 27, 2026 15:14
luisgutierrezpereda
force-pushed
the
SEN-1768-fix-convergence-of-smooth-extrapolated-position
branch
from
September 9, 2026 14:56
9d1f053 to
e8cb22d
Compare
Fix ls command to correctly display tags and styles for opened sessions and buses, even when they don't contain any objects resolves SEN-1777
luisgutierrezpereda
force-pushed
the
SEN-1768-fix-convergence-of-smooth-extrapolated-position
branch
from
September 10, 2026 08:38
e8cb22d to
a818de5
Compare
Collaborator
Hello @EnriqueParodi. The removal of term_->newLine() just removes a redundant new line that appeared before the 'shell opened' log when you opened a bus. Now the log appears inmediatly after the prompt, which looks better. |
luisgutierrezpereda
force-pushed
the
SEN-1777-bus-going-out-of-scope-creates-weird-behavior-in-shell
branch
from
September 10, 2026 08:50
5f0a992 to
75de554
Compare
EnriqueParodi
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
lscommand to correctly display tags and styles for opened sessions and buses, even when they don't contain any objectsResolves SEN-1777