馃悰 cd: pin RabbitMQ to the image ci uses - #124
Merged
Merged
Conversation
`cd.yml` requested `rabbitmq:latest`, which now resolves to RabbitMQ 4.x. That release stops permitting `transient_nonexcl_queues` by default, and `kiwipy` declares exactly those queues, so every test that submits to the daemon dies on `queue.declare` with an `INTERNAL_ERROR` naming that feature. `ci.yml` pins `rabbitmq:3.8.14-management`, so the two workflows were running against different brokers and only `cd` could hit this. Since `cd` runs on tag pushes alone, the breakage stayed invisible until a release was cut and then blocked publishing. Use the same image in both. Matching them also removes the drift that let a green `ci` imply a green `cd`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd.ymlrequestedrabbitmq:latest, which now resolves to RabbitMQ 4.x. That release stops permittingtransient_nonexcl_queuesby default, andkiwipydeclares exactly those queues, so every test that submits to the daemon dies onqueue.declarewith anINTERNAL_ERRORnaming that feature.ci.ymlpinsrabbitmq:3.8.14-management, so the two workflows were running against different brokers and onlycdcould hit this. Sincecdruns on tag pushes alone, the breakage stayed invisible until a release was cut and then blocked publishing.Use the same image in both. Matching them also removes the drift that let a green
ciimply a greencd.