Blaham17 people parcels share - after project - #66
Open
F-I-D-O wants to merge 39 commits into
Open
Conversation
…anComputationRequests
…anComputationRequests
…anComputationRequests
… these vehicles. But the PeopleFreightVehicle doesn't work now
… - problem with OnDemandVehicle and genericity of 'V'
F-I-D-O
commented
Feb 20, 2022
| @@ -0,0 +1,83 @@ | |||
| /* | |||
Member
Author
There was a problem hiding this comment.
What is the purpose of this class?
Comment on lines
102
to
109
| // max distance in meters between vehicle and request for the vehicle to be considered to serve the request | ||
| // maxDistance = (double) config.ridesharing.maxProlongationInSeconds | ||
| // * agentpolisConfig.maxVehicleSpeedInMeters; | ||
|
|
||
| // the traveltime from vehicle to request cannot be greater than max prolongation in milliseconds for the | ||
| // vehicle to be considered to serve the request | ||
| // maxDelayTime = config.ridesharing.maxProlongationInSeconds * 1000; | ||
| } |
Member
Author
There was a problem hiding this comment.
You should not modify this!
| this.positionUtil = positionUtil; | ||
| this.tripIdGenerator = tripIdGenerator; | ||
|
|
||
| public class RideSharingOnDemandVehicle<V extends PhysicalTransportVehicle> extends OnDemandVehicle<V> |
Member
Author
There was a problem hiding this comment.
You have reformated the whole class here, so now I cannot see the diff. You have to convert the indent back to tabs and also change the settings in your IDE to use tabs.
| } | ||
| } | ||
|
|
||
| public class InsertionHeuristicSolver extends DARPSolver implements EventHandler |
Member
Author
There was a problem hiding this comment.
Same problem here with the space indent
| import cz.cvut.fel.aic.simod.entity.DemandAgent; | ||
| import cz.cvut.fel.aic.simod.traveltimecomputation.TravelTimeProvider; | ||
|
|
||
| public class PlanComputationRequestPeople extends DefaultPlanComputationRequest |
Member
Author
There was a problem hiding this comment.
You can use DefaultPlanComputationRequest instead of this class, as there are no extra members.
| /** | ||
| * returns sorted list of new taxi schedule (or null if the schedule is not feasible) and duration of this schedule | ||
| */ | ||
| private ScheduleWithDuration trySchedule(int taxiIndex, DefaultPlanComputationRequest newRequest) |
Member
Author
There was a problem hiding this comment.
This method seems very inefficient, but if it is implemented according to the article, I guess we can leave it for now.
Comment on lines
+17
to
+18
| protected final List<T> transportedEntities; | ||
| private final int vehiclePassengerCapacity; |
Member
Author
There was a problem hiding this comment.
You should use the infrastructure from parent for this
Comment on lines
+46
to
+63
| public void setPosition(SimulationNode position) | ||
| { | ||
| super.setPosition(position); | ||
| Iterator var2 = this.transportedEntities.iterator(); | ||
|
|
||
| while (var2.hasNext()) | ||
| { | ||
| T transportedEntity = (T) var2.next(); // originally was (TransportableEntity) | ||
| transportedEntity.setPosition(position); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| public List<T> getTransportedEntities() | ||
| { | ||
| return transportedEntities; | ||
| } |
Comment on lines
+81
to
+89
| public boolean isHighlited() | ||
| { | ||
| return this.highlited; | ||
| } | ||
|
|
||
| public void setHighlited(boolean highlited) | ||
| { | ||
| this.highlited = highlited; | ||
| } |
…, all vehicles should be working now
…ported people and packages
Former-commit-id: c500c6d2c9a857356eaf411bdae6016ec8b93efb
Former-commit-id: 55f7a25f133ba2122d48e40d4ab866c9d6f71e9e
Former-commit-id: f64f09ab135adfd23eadcf33de6d79f0cfede783
Former-commit-id: 036a2f95c7f5c790fc3c7645e171ae1b966d8d4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.