fix(ci): warm lifecycle dependency checks - #66
Conversation
| run: sh scripts/provision-rust-ci-stubs.sh | ||
|
|
||
| - name: Warm mc-host dependency graph | ||
| run: cargo tree -p mc-host -e normal >/dev/null |
There was a problem hiding this comment.
Nit: check-plugin doesn't set up a Rust toolchain anywhere in this job (no dtolnay/rust-toolchain@stable step, unlike shm-crash-recovery, shm-source-build, and mc-host-lifecycle), so this step relies entirely on whatever cargo/rustc happens to be preinstalled on the ubuntu-latest runner image. That's not a new dependency introduced by this PR — the dependency-boundary test already invoked cargo tree in-process here — but now that a dedicated step exists, it'd be more robust/consistent to add an explicit toolchain step before it, so a runner-image change (or version drift between this job and the other Rust jobs) doesn't cause a silent failure that's hard to trace back to "no toolchain installed."
ReviewSmall, well-targeted change: adding a dedicated "Warm mc-host dependency graph" step ( Assessment:
One nit left as an inline comment: this job never installs a Rust toolchain explicitly (unlike No security or performance concerns beyond the above — this only affects CI plumbing. |
5b8c053 to
762dfc1
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by gemini-3.7-flash · Input: 117.7K · Output: 6.2K · Cached: 293.4K |
Summary
Plugin CI now warms the exact
mc-hostdependency graph after provisioning metadata-only sibling manifests. The release dependency-boundary test remains strict but no longer spends its five-second test budget downloading crates on the firstcargo treeinvocation.Verification
cargo tree -p mc-host -e normalStack
Layer 8 of 8 above #46. Parent: #65.