Fix GensetModule.sample_action() raising TypeError on strict_bound=True - #120
Open
petermllrr wants to merge 1 commit into
Open
Fix GensetModule.sample_action() raising TypeError on strict_bound=True#120petermllrr wants to merge 1 commit into
GensetModule.sample_action() raising TypeError on strict_bound=True#120petermllrr wants to merge 1 commit into
Conversation
Owner
|
Could you add a unit test in test_genset_module.py with an example of the failure this PR fixes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
Replaces the delegation to
super().sample_action()inGensetModulewith an implementation that handles the module's 2-dimensional action space.GensetModuledefines a 2D action space[on_off_flag, power_setpoint], but itssample_actiondelegated the power component toBaseModule.sample_action().BaseModuleassumes a scalar action space and callsself._action_space.normalize(self.max_production), passing a scalar into a shape-(2,)space. The shape check inspace.pythen raises:📚 Documentation preview 📚: https://python-microgrid--120.org.readthedocs.build/en/120/