fix(browser): allow fixture to override maxColumns and maxNestedDepth - #227
Open
SparshM8 wants to merge 1 commit into
Open
fix(browser): allow fixture to override maxColumns and maxNestedDepth#227SparshM8 wants to merge 1 commit into
SparshM8 wants to merge 1 commit into
Conversation
Resolves agentrhq#218. Updates FixtureExpect schema and validateRowShape to respect maxColumns and maxNestedDepth options, allowing spreadsheet-export adapters to legitimately return wide rows without failing the CLI verify step.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #218.
This PR updates the
FixtureExpectschema and thevalidateRowShapelogic to respectmaxColumnsandmaxNestedDepthoverrides. Previously, the browser verify step strictly hardcoded the caps to 12 columns and a nesting depth of 1, which caused legitimate spreadsheet-export adapters to fail CI.By adding these options, adapter authors can now explicitly permit wider rows or deeper nesting in their
verify/<cmd>.jsonexpectations without disabling shape validation entirely.Related issue: #218
Type of Change
Checklist
Adapter Notes
CliErrorsubclasses instead of rawErrorScreenshots / Output
N/A - CLI output remains the same, but adapters with wide rows will now pass
webcmd browser verifywithout throwing shape errors.