Skip to content

feat: browser run playwright sandbox - #196

Merged
beubax merged 62 commits into
mainfrom
feat/browser-run-playwright-sandbox
Aug 6, 2026
Merged

feat: browser run playwright sandbox#196
beubax merged 62 commits into
mainfrom
feat/browser-run-playwright-sandbox

Conversation

@beubax

@beubax beubax commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

Findings

  1. README — The browser command subcommands (click, type, extract, network, etc.) are replaced by a Playwright sandbox run and snapshot commands.
    • Changed: skills/webcmd-browser/SKILL.md
    • Evidence: The raw surface is 'tabs', 'bind --page', 'snapshot', 'run', and 'close'.
    • Suggested update: README.md
    • Why: The README.md file is marked as modified in the inventory but its patch is not in this chunk, so we must verify it no longer references the removed browser subcommands (click, type, extract, network).
  2. DOCS — The browser command subcommands (click, type, extract, network, etc.) are replaced by a Playwright sandbox run and snapshot commands.
    • Changed: skills/webcmd-browser/SKILL.md
    • Evidence: The raw surface is 'tabs', 'bind --page', 'snapshot', 'run', and 'close'.
    • Suggested update: docs/cli-reference.mdx
    • Why: The docs/cli-reference.mdx file is marked as modified in the inventory but its patch is not in this chunk, so we must verify it correctly documents the new Playwright sandbox commands (run, snapshot) instead of the old browser subcommands.
  3. SKILL — Removal of almost all individual browser interaction subcommands (click, type, fill, select, extract, eval, frames, network, etc.) in favor of a Playwright-based `run` command and a simplified `snapshot` command.
    • Changed: src/browser/command-catalog.ts
    • Evidence: command('run', 'Run JavaScript with Playwright', 'run', [], [
    • Suggested update: skills/webcmd-browser/SKILL.md
    • Why: The browser skill documentation in the default branch contains extensive guides, recipes, and troubleshooting steps for the deleted subcommands. Since the modified SKILL.md patch is not fully visible, a review is suggested to ensure it has been updated to reflect the new Playwright sandbox execution model.
  4. DOCS — The recommended way to interact with cross-origin iframes changes from using `browser frames` and `browser eval` to using `browser <session> run --stdin` with `page.frames()[index]`.
    • Changed: src/browser/dom-snapshot.ts
    • Evidence: lines.push(indent + '|iframe|' + frameLabel + '<iframe' + (attrs ? ' ' + attrs : '') + ' /> (cross-origin, use: webcmd browser <session> run --stdin and page.frames()[index])');
    • Suggested update: docs/cli-reference.mdx
    • Why: The CLI reference documentation needs to be reviewed to ensure it correctly documents the new cross-origin iframe interaction pattern and removes references to the deleted `frames` and `eval` subcommands.
  5. SKILL — Introduction of a Playwright sandbox client for running browser instances.
    • Changed: src/browser/run/playwright-client/vendor/client/browser.ts
    • Evidence: export class Browser extends ChannelOwner<channels.BrowserChannel> implements api.Browser {
    • Suggested update: skills/webcmd-browser/SKILL.md
    • Why: The PR adds a Playwright sandbox client. Since the documentation patches are not in this chunk, we should verify that the browser skill accurately reflects how to use or interact with this new sandbox environment.

Limitations

  • Some review context was unavailable or reduced.
  • Some automated findings could not be verified against the pull request diff.

This review is advisory and does not block merging.

beubax added 29 commits August 5, 2026 12:01
Browser tests require Playwright binaries which are system-level dependencies, not a Bun compatibility issue. Bun testing should focus on runtime compatibility.
…wser run --stdin` and update documentation for session management and auth handoff.
@beubax
beubax merged commit b51cac3 into main Aug 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants