chore(e2e): tag suite traffic with x-client-type: test - #283
Merged
Conversation
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Estate test-traffic contract: every e2e/synthetic request must carry
x-client-type: test. The edge classifier (Traefik -> Vector) and@agentage/observabilityspan stamping key on exactly this header; UA sniffing is only a fallback. This suite signs up throwaway accounts against a live Better Auth AS (auth.<AGENTAGE_SITE_FQDN>), all of it untagged today.What
e2e/client-type.ts- single source for the header (local const; no shared package here).playwright.config.tsgains ause.extraHTTPHeadersdefault (the config had nouseblock at all).e2e/helpers.tsnewBrowserContext():apiRequest.newContextpasses its ownextraHTTPHeaders(Origin), which REPLACES the config default per key - so it spreads the tag explicitly.mcp-contract.test.ts/mcp-daemon.test.tstag theirfetchtoo (loopback today, but keeps the contract uniform).Known gap
Requests the CLI subprocess makes to the live stack (OAuth, sync over git smart-HTTP) still go out untagged - the test harness cannot inject a header into the built binary. Closing that needs a client-side hook in the CLI itself (e.g. honoring an
AGENTAGE_CLIENT_TYPEenv var); flagged, not fixed here.Verified
prettier --checkclean;playwright test --listloads the config (44 tests in 11 files). No suite run against a deployed stack.