fix: diagnose locality-restricted resume failures instead of generic error#453
Closed
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Closed
Conversation
…error When a local snapshot restricts resume to specific nodes and no worker is picked, distinguish a real locality conflict (all eligible workers on those nodes are busy, or the nodes have no eligible workers at all) from cluster-wide capacity exhaustion, instead of the generic FailedPrecondition: no free workers available. Fixes agent-substrate#398
Contributor
Author
|
Dmitry Berkovich (@dberkov) would you mind taking a look when you get a chance? |
Collaborator
|
#401 seems already fixed it but need a rebase |
Contributor
Author
|
Closing in favor of #401, which covers the same diagnostic and does it more efficiently (single pass via workerScan vs. this PR's two passes), and was opened first (2026-07-06). Thanks Haven Xia (@HavenXia) for flagging. |
Mesut Oezdil (mesutoezdil)
deleted the
fix/resume-locality-error-diagnostics
branch
July 17, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locality-restricted resume failures now say why instead of the generic "no free workers available": either the restricted node's eligible workers are all busy, or the node has no eligible workers at all (may have been removed). Status code unchanged, message only.
Test plan:
go build ./...,go test ./cmd/ateapi/..., addedTestNoFreeWorkerError.Fixes #398