Add CheckPrerequisite to WorkflowStep to validate state machine edges#374
Merged
Dmitry Berkovich (dberkov) merged 7 commits intoJul 21, 2026
Merged
Conversation
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
4 times, most recently
from
July 8, 2026 23:55
9e8acdf to
3921ac8
Compare
Zoe Zhao (zoez7)
commented
Jul 8, 2026
Zoe Zhao (zoez7)
marked this pull request as ready for review
July 8, 2026 23:58
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
from
July 9, 2026 00:26
3921ac8 to
ec3b70c
Compare
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
from
July 9, 2026 00:38
ec3b70c to
4104a7d
Compare
github-project-automation
Bot
moved this to Todo
in Substrate Milestones (go/substrate-milestones)
| return nil | ||
| } | ||
| func (s *CallAteletPauseStep) Execute(ctx context.Context, input *PauseInput, state *PauseState) error { | ||
| if state.Actor.GetAteomPodNamespace() == "" || state.Actor.GetAteomPodName() == "" { |
Collaborator
There was a problem hiding this comment.
this is a pre-requisite too, however function in current implementation does not support transition to crashActor.
Might be rename the "CheckPrerequisite" to different name? might be allow transition to crash? or might be from the beginning we were not supposed to be in this state, that actor does not have pod or namespace?
Collaborator
Author
There was a problem hiding this comment.
We should crash the actor here. We can only get here if MarkPausing has succeeded, not having the ateom pod or namespace should crash the actor. I changed the implementation.
| return nil | ||
| } | ||
| func (s *CallAteletPauseStep) Execute(ctx context.Context, input *PauseInput, state *PauseState) error { | ||
| if state.Actor.GetAteomPodNamespace() == "" || state.Actor.GetAteomPodName() == "" { |
Collaborator
Author
There was a problem hiding this comment.
We should crash the actor here. We can only get here if MarkPausing has succeeded, not having the ateom pod or namespace should crash the actor. I changed the implementation.
…o check the worker eligibility again if previous attempt failed after setting actor to RESUMING state. If the worker becomes ineligible, set the actor to crashed state.
Zoe Zhao (zoez7)
force-pushed
the
check-prerequisite
branch
from
July 12, 2026 01:54
5ba9448 to
6d976cf
Compare
Dmitry Berkovich (dberkov)
merged commit Jul 21, 2026
4ecf3fb
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369
Add a CheckPrerequisite method to the WorkflowStep interface, called by RunWorkflow after IsComplete returns false and before Execute, so that each workflow validates its actor state-machine edge up front while retried (reentrant) workflows still fast-forward past completed steps.