feat(web): add file search to the explorer sidebar - #591
Merged
Conversation
Add a search button to the explorer toolbar that toggles a debounced
filename search input, backed by a new search request type on
/api/files. Results are ranked by filename relevance (exact name,
prefix, name substring, then path substring), skip ignored
directories/suffixes, and are capped at 200 entries.
Search results render as an expandable directory tree (directories
first, alphabetical, multi-level nesting) that replaces the file tree
while a query is active, with per-row mention and download hover
actions matching the regular file tree.
Refactor:
- extract search logic to lib/file-search.ts and tree folding to
lib/search-tree.ts
- add node:test unit suites for both modules (ranking, ignoring,
limits, symlink loops, tree grouping/sorting) and update the
sidebar UI wiring tests
- add en/zh-CN translations for search UI strings
zaocj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a search button to the explorer toolbar that toggles a debounced
filename search input, backed by a new search request type on
/api/files. Results are ranked by filename relevance (exact name,
prefix, name substring, then path substring), skip ignored
directories/suffixes, and are capped at 200 entries.
Search results render as an expandable directory tree (directories
first, alphabetical, multi-level nesting) that replaces the file tree
while a query is active, with per-row mention and download hover
actions matching the regular file tree.
Refactor: