Skip to content

Adopt/prepared packet v0 - #535

Open
BartolomeyKant wants to merge 19 commits into
mainfrom
adopt/prepared-packet-v0
Open

Adopt/prepared packet v0#535
BartolomeyKant wants to merge 19 commits into
mainfrom
adopt/prepared-packet-v0

Conversation

@BartolomeyKant

@BartolomeyKant BartolomeyKant commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

THis is continuation of work from branch #531
Code was rebased on last main and conflict was fixed.

Comment thread aether/prepared_packet/prepared_send_message.h Outdated
Comment thread aether/stream_api/api_call_adapter.h Outdated
Comment thread aether/stream_api/api_call_adapter.h Outdated
std::array<uint8_t, sizeof(base_station.target_bssid)> debug_bssid;
memcpy(debug_bssid.data(), base_station.target_bssid,
sizeof(base_station.target_bssid));
AE_TELED_DEBUG("Restored from cash BSSID:{} CHN:{}", debug_bssid,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information also should be passed into the prepared block or other "stats" block so when a normal ae client patch is used it is inserted into tele allowing to check how often wifi opts were used

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't make prepared block for wifi yet.

Again I don't think we should store telemetry for prepared blocks.
Either we use as small and fast implementation as possible or use full aether client implementation.

@NikolayChirkov NikolayChirkov Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need a separate minimal RTC-resident statistics block, independent of the prepared message block. The full Aether client should import these numeric counters into normal telemetry on the next full-path run and then clear them. Keep only Aether-related data: successful channel-cache/BSSID/static-IP uses (we want to count devices where each optimization works) and the total number of prepared sends, which we can compare with the number received by the server to estimate loss. Do not collect socket/sendto success, failures, retries, or would-block events: that code is external to Aether. nonce_exhausted is also unnecessary because the reserved block size is already known.

@BartolomeyKant

Copy link
Copy Markdown
Collaborator Author

@NikolayChirkov you've reviewed old version. I completely rebuild it.

@BartolomeyKant
BartolomeyKant marked this pull request as ready for review August 24, 2026 15:18

@NikolayChirkov NikolayChirkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two additional issues in the current head.

Comment thread aether/connection_manager/client_cloud_manager.cpp Outdated
Comment thread aether/prepared_packet/prepared_send_message_block.h Outdated
@BartolomeyKant
BartolomeyKant force-pushed the adopt/prepared-packet-v0 branch 2 times, most recently from 30e15da to db3ba69 Compare August 25, 2026 14:32
@BartolomeyKant
BartolomeyKant force-pushed the adopt/prepared-packet-v0 branch 2 times, most recently from 2db58cb to a11aeca Compare August 26, 2026 07:31
add endpoint() property for channel
add method to get cached cloud
@BartolomeyKant
BartolomeyKant force-pushed the adopt/prepared-packet-v0 branch 2 times, most recently from 9f0ecd0 to e7ed374 Compare August 27, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants