feat(donut-s2): add sentiment-colored delta line to DonutSummary - #900
Open
madelineluke wants to merge 2 commits into
Open
feat(donut-s2): add sentiment-colored delta line to DonutSummary#900madelineluke wants to merge 2 commits into
madelineluke wants to merge 2 commits into
Conversation
madelineluke
force-pushed
the
feat/donut-summary-delta-line
branch
from
September 3, 2026 16:15
2f3bd1b to
be1b63b
Compare
Adds an optional third line to DonutSummary - a bold, sentiment-colored delta value (e.g. "+2.5%" green / "-7.4%" red) rendered below the label. Reuses the existing label font-size signal directly (the delta ramp is identical), and generalizes the value/label stacking logic so any combination of value/label/delta positions correctly, including delta taking over the label's slot when label is omitted, and label becoming the anchor line when hideValue is set with delta present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…e smells in donutSummaryUtils Extracts baseline/heightFromCenter/dyExpr nested ternaries into if/else chains, and pulls the nested template literal in getSummaryDeltaEncode's dyExpr into a named valueGapExpr constant first. No behavior change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
madelineluke
force-pushed
the
feat/donut-summary-delta-line
branch
from
September 8, 2026 21:49
5720825 to
9251f52
Compare
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-900 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-900-s2 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-900-docs/ |
madelineluke
removed this pull request from stack #898
September 9, 2026 22:41
madelineluke
added this pull request to stack #908
September 9, 2026 22:42
madelineluke
removed this pull request from stack #908
September 9, 2026 22:42
madelineluke
added this pull request to stack #909
September 9, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delta?: numberprop toDonutSummary- a bold, sentiment-colored delta line (e.g.+2.5%green /-7.4%red) rendered below the label, perplanning/specs/donut/implemented/donut-summary-delta-line.json.hideValueis set with delta present.isBooleandonut summary variants.Test plan
yarn test --testPathPattern="donut"- 236 passed (17 new)yarn tsc --noEmit- no new errorsyarn lint- clean🤖 Generated with Claude Code