fix: remove unused crypto-js dependency (APPBLD-4862) - #89
Merged
AnujVishwakarma-src merged 2 commits intoSep 9, 2026
Merged
Conversation
crypto-js@4.2.0 is deprecated (active development discontinued) but is a dead dependency here: it is not imported anywhere in src/test/e2e. Signature verification in src/signatureUtils.js already uses Node built-in crypto (crypto.verify/createPublicKey), so crypto-js is pure leftover from the initial open-sourcing commit. Removing it clears the crypto-js deprecation warning (clean npm install: 16 -> 15 warnings, only crypto-js removed). No code change; unit tests 105/105 pass with 100% coverage, lint clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aroragarvit666-hue
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
crypto-jsdependency.Why
crypto-js@4.2.0is deprecated ("Active development of CryptoJS has been discontinued"), but it is a dead dependency in this package:src/,test/, ore2e/(verified viagit grep).npm ls crypto-jsshows it with no other consumer.src/signatureUtils.jsalready uses Node's built-incrypto(crypto.verify('rsa-sha256', …),crypto.createPublicKey(…)).So this is a straight removal — no replacement or code change needed.
Evidence
Clean
npm installdeprecation warnings: 16 → 15, with the only difference being:Validation
signatureUtils.js)crypto-jsno longer present in the dependency tree🤖 Generated with Claude Code