Screenshots: target iOS 26 sims + run capture on CI - #36
Open
adborbas wants to merge 1 commit into
Open
Conversation
capture-screenshots.sh now selects only iOS 26+ simulators (highest version wins) so screenshots show the iOS 26 Liquid Glass styling, and fails loudly if a required device is missing on that runtime. It also honours SCREENSHOT_XCODEBUILD_ARGS so CI can disable code signing (simulator builds need none). Adds an 'App Store Screenshots' workflow_dispatch workflow that runs the script on the Xcode 26 image and uploads the result as an artifact, and wires the same signing-flag env into the existing promo-screenshots job (resolving its TODO). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
scripts/capture-screenshots.sh:SCREENSHOT_XCODEBUILD_ARGSenv var, appended toxcodebuild test(empty locally; CI uses it to disable code signing)..github/workflows/screenshots.yml(new): an App Store Screenshotsworkflow_dispatchworkflow that runs the script on the Xcode 26 image with signing disabled and uploads the shots as an artifact..github/workflows/release.yml: pass the same signing-flag env into the existingpromo-screenshotsjob (it callscapture-screenshots.shtransitively), resolving its stale TODO.Why
The capture script previously grabbed whichever runtime was newest and was never wired into CI. Pinning to iOS 26 gets the Liquid Glass look, and a dedicated workflow makes screenshot generation reproducible on the CI Xcode 26 image (which guarantees the iOS 26 sims) rather than a local machine.
Notes
workflow_dispatchrun; the script now errors clearly if a device isn't present.bash -npasses under bash 3.2 (runner version), the empty-array guard is safe underset -u, and both workflows are valid YAML.