refactor(http): return Option<&str> from HttpMessage::content_type - #4229
Draft
Sruhvx-jpg wants to merge 1 commit into
Draft
refactor(http): return Option<&str> from HttpMessage::content_type#4229Sruhvx-jpg wants to merge 1 commit into
Sruhvx-jpg wants to merge 1 commit into
Conversation
Update HttpMessage::content_type to return Option<&str> instead of &str, avoiding empty string sentinels. Update UrlEncoded extractor and tests accordingly. Closes actix#3797
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Overview
Returns
Option<&str>fromHttpMessage::content_type()instead of an empty string sentinel, and updatesUrlEncodedand tests to match.Supersedes #3827. Closes #3797.