Skip to content

Fix Connection and Expect header parsing - #4179

Open
WaterWhisperer wants to merge 6 commits into
actix:mainfrom
WaterWhisperer:http-connection-expect
Open

Fix Connection and Expect header parsing#4179
WaterWhisperer wants to merge 6 commits into
actix:mainfrom
WaterWhisperer:http-connection-expect

Conversation

@WaterWhisperer

@WaterWhisperer WaterWhisperer commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

  • Parse comma-separated Connection options with close taking precedence.
  • Parse Expect headers and only recognize 100-continue.
  • Correct misleading content-encoder trace messages and the zstd typo.

See RFC 9110 §7.6.1 and RFC 9110 §10.1.1.

Closes #2692

@github-actions github-actions Bot added the A-http project: actix-http label Aug 8, 2026

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I'm not a HTTP spec expert so I might be missing something but leaving some concerns. cc @robjtede for additional reviews.

Comment thread actix-http/src/h1/decoder.rs
Comment thread actix-http/src/h1/decoder.rs Outdated
Comment thread actix-http/src/h1/decoder.rs Outdated
@github-actions github-actions Bot added A-awc project: awc A-web project: actix-web labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-awc project: awc A-http project: actix-http A-web project: actix-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

define behavior when multiple Connection header values are provided

2 participants