ImageMap FULL PR5: harden LFS/CI, C3 best-effort docs, known gaps - #14
Draft
aceRage wants to merge 2 commits into
Draft
ImageMap FULL PR5: harden LFS/CI, C3 best-effort docs, known gaps#14aceRage wants to merge 2 commits into
aceRage wants to merge 2 commits into
Conversation
No new feature surfaces. Document C3 as unsupported/best-effort, refuse a missing LFS LUT at cmake/CI, and list residual gaps for the stacked PR1–PR5 pack. Co-authored-by: aceRage <aceRage@users.noreply.github.com>
|
❌ Documentation validation failed 🔗 Link Validation Errors📄 doc/developer-reference\Built-in-placeholders-variables.md:
📄 doc/developer-reference\How-to-build.md:
📄 doc/developer-reference\How-to-wiki.md:
📄 doc/Home.md:
📄 doc/Tab.cpp:
🖼️ Image Validation Errors📄 doc/developer-reference\How-to-create-profiles.md:
|
The wiki validator indexes only doc/ and a How-to-build touch reports the pre-existing wiki-link backlog. Keep LFS notes in docs/README. Add `cd … || exit` in spike verify scripts so repo-wide Shellcheck (triggered by build_linux.sh) passes. Co-authored-by: aceRage <aceRage@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ImageMap FULL PR5 (harden + LFS/CI reliability + known-gaps docs). No new feature surfaces.
Feature-patch extract from OrcaSlicer-ImageMap
@92548381056(v1.0.44lineage). Does not merge ImageMapmain.Stack / base tip
cursor/feat-imagemap-full-pr4-ui-f9c3(draft PR Add ImageMap FULL PR4 UI (zones, gizmos, gated preview) #13 tipe3e839962758b61bbb3542696b11c931bf79ef91)cursor/feat-imagemap-full-pr5-harden-02d1mainuntil the stack is reviewed. Code Team does not merge. Do not close sibling ImageMap PRs.Locked product decisions (unchanged)
lut_wide.png.cvia Git LFSPaintDepth.*/paint_depth_*/test_paint_depth*.cppWhat this PR does
docs/imagemap-full-known-gaps.mdanddocs/imagemap-full-pr5.md. Crash-only test[texturemapping][pr5][c3]intests/libslic3r/test_texture_mapping.cpp. Does not assert combined visual correctness..gitattributesalready tracksdeps_src/pigment-painter/lut_wide.png.c(38094965 bytes).pigment_paintercmake FATAL_ERRORs if the file is missing or still a Git LFS pointer (verified: configure stops with the explicit message).build_orca.ymlre-checks afterlfs: truecheckout.build_linux.shrefuses to compile on a pointer. Build docs:README.md,CLAUDE.md,AGENTS.md,deps_src/pigment-painter/README.md.MMUPaintedTexturePreviewheaviest halftone paths stay off by default. Defaults documented +[texturemapping][pr5]assertion. Offset weight field stays on the slice path.docs/imagemap-full-known-gaps.md: ships vs gaps, residual TODOs, Claude-manager merge rules, REAPER smoke.LayerToolsTM vectors.spike/verify_chameleon.sh/verify_paintdepth.sh:cd … || exitonly (Shellcheck SC2164) so repo-wide Shellcheck stays green. No paint-depth formula change.CI follow-up (this revision)
The first commit linked
docs/imagemap-full-pr5.mdfromdoc/developer-reference/How-to-build.md. The wiki validator indexes onlydoc/, so that link was “missing”, and touching anydoc/**/*.mdreports the entire pre-existing wiki-link backlog (Home.md, Tab.cpp paint-depth fragments, How-to-wiki, image alt text, etc.). Those are not PR5 regressions.Fix: How-to-build.md is restored to the PR4 tip (net-zero vs #13). LFS notes stay in
docs/+ README. Shellcheck SC2164 in the two spike verify scripts is fixed because changingbuild_linux.shruns repo-wide Shellcheck.Files touched (net vs PR4)
docs/imagemap-full-pr5.md(new)docs/imagemap-full-known-gaps.md(new)docs/imagemap-full-pr1.md…pr4.md(cross-links)deps_src/pigment-painter/CMakeLists.txt/README.md.github/workflows/build_orca.ymlbuild_linux.shREADME.md,CLAUDE.md,AGENTS.mdsrc/libslic3r/GCode/ToolOrdering.hpp(stub comments)src/libslic3r/TextureMapping.hpp(conservative-default comments)tests/libslic3r/test_texture_mapping.cppspike/verify_chameleon.sh,spike/verify_paintdepth.sh(cd || exitonly)Not touched (net):
How-to-build.md,PaintDepth.*,test_paint_depth*.cpp, Plater/PartPlate/AMS/SendJob/Stream/Remote, GLTF, prime-tower images.LFS / cmake checks
Cloud still has the LFS pointer. Isolated cmake of
deps_src/pigment-painterFATAL_ERRORs as intended.C3 stance
Unsupported / best-effort. No marketing claim. Crash-only automated case + manual REAPER checklist.
Known-gaps path
docs/imagemap-full-known-gaps.mdanddocs/imagemap-full-pr5.md.Ships: side texture + Contoning + Remap + ImportedTexture + full UI + LFS LUT + wipe-tower TM count.
Gaps: no
.gltf/.glb; no prime-tower images; C3 best-effort; no calibration Electron app; TD sheets optional static docs only.Claude manager: stack PR1–PR5; smoke gates before merge; Code Team does not merge.
Forbidden-region greps (this PR vs PR4 tip)
Tests
test_paint_depth*.cppuntouched.[texturemapping][pr5]+[texturemapping][pr5][c3].libslic3r_tests.Owed REAPER smoke (required before merge)
Screenshots/Recordings/Graphs
Docs / cmake / tests only — no UI change.
Tests
Cloud: cmake LUT pointer FATAL_ERROR verified. Full
[texturemapping]/[paintdepth]owed on REAPER aftergit lfs pull+ rebuild.