Resolve issues #605, #606, #607, #608#615
Merged
Chucks1093 merged 1 commit intoJul 24, 2026
Merged
Conversation
…yerorg#607, accesslayerorg#608 - Add buildPaginatedResponse<T> helper for cursor-based pagination envelopes (has_more/next_cursor from an over-fetched result set), with unit tests covering exact limit, over limit, under limit, and empty result set (accesslayerorg#605) - Add integration tests exercising the full price alert lifecycle: create an alert, cross the threshold on a price snapshot update, confirm delivery is attempted and the alert is marked triggered, and confirm it is not re-queued on the next snapshot update (accesslayerorg#606) - Document each supported webhook event type (buy, sell) with its own example payload and a note on nullable/optional fields (accesslayerorg#607) - Add a test covering the wallet activity feed helper returning an empty array when there are no activities, regardless of the type filter (accesslayerorg#608) Closes accesslayerorg#605 Closes accesslayerorg#606 Closes accesslayerorg#607 Closes accesslayerorg#608
|
@JamesVictor-O Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildPaginatedResponse<T>helper for cursor-based pagination envelopes (has_more/next_cursorfrom an over-fetched result set), with unit tests covering exact limit, over limit, under limit, and empty result setbuy,sell) with its own example payload and a note on nullable/optional fieldsCloses #605
Closes #606
Closes #607
Closes #608
Test plan
pnpm exec jest pagination.utils wallet-activity.service.integration alert-lifecycle-threshold-crossing— all 14 tests passpnpm test— full suite run; no new failures introduced (remaining failures are pre-existing, due to no local Postgres instance being available in this environment)pnpm lint— cleanpnpm build— clean