Fix compilation errors: add max_keys_per_wallet parameter to register…#570
Merged
Chucks1093 merged 3 commits intoJul 23, 2026
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation errors across the creator-keys test suite by updating all register_creator and try_register_creator function calls to include the newly added seventh parameter max_keys_per_wallet.
Changes:
Added the missing &None argument for max_keys_per_wallet to all register_creator calls in test files
Fixed parameter order in transfer_keys_dividend_preservation.rs where CurvePreset was incorrectly positioned
Updated 307 files across the test suite
Testing:
All compilation errors (E0061) have been resolved
All 200+ tests pass successfully
Codebase compiles cleanly
Context: The register_creator function signature was updated to include a seventh parameter max_keys_per_wallet of type &Option. This change was not reflected in the test files, causing compilation errors. This PR systematically updates all test calls to match the new function signature.
closes #548