test: buy-then-sell round-trip returns correct XLM to seller#568
Merged
Chucks1093 merged 2 commits intoJul 21, 2026
Merged
Conversation
Add integration test from supply 0: buy one key, sell it, assert seller net XLM equals sell-price minus creator and protocol fees, and supply returns to 0. Addresses issue accesslayerorg#560 only.
Fix cargo fmt --check failures that blocked the verify CI job.
Closed
4 tasks
Contributor
|
Nice work @soomtochukwu . I will merge this now and hit up when I create more issues on accesslayer. Thanks for contributing |
Contributor
Author
... looking forward to it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added an integration test for a sequential buy-then-sell round-trip starting from a fresh creator at supply 0. After buying one key and selling it immediately, the seller’s net proceeds match the sell-step price minus creator and protocol fees, and supply returns to 0.
I only tackled issue #560. No contract logic or unrelated tests were changed.
What the test asserts
total_amount(price + fees); fee ledgers move by quote feesprice - creator_fee - protocol_feeand matchescompute_fees_for_paymentRelated Issue
Closes #560
Test plan
Scope
I only resolved #560.