test(governance-polls): verify vote change updates tally without double counting#566
Merged
Chucks1093 merged 1 commit intoJul 23, 2026
Conversation
…le-counting Add a regression test covering a holder who changes their vote before a poll expires. Wallet A votes option 0 with 10 keys, then switches to option 1. Asserts option 0 tally decrements by 10, option 1 increments by 10, and total vote weight stays unchanged, confirming the previous weight is removed rather than double-counted.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test covering a holder who changes their vote before a poll
expires. Wallet A votes option 0 with 10 keys, then switches to option 1.
Asserts option 0 tally decrements by 10, option 1 increments by 10, and total
vote weight stays unchanged, confirming the previous weight is removed rather
than double-counted.
Summary
changing_vote_before_expiry_removes_previous_weight_without_double_countingto
creator-keys/tests/governance_polls.rsoption 1
tally (option 0 = 0, option 1 = 10, total = 10), proving weight moves rather
than accumulates
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
creator-keysunit/integration tests for every changed contract behavior, including failure paths for new or reachableContractErrorvariantscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspace, or explained exactly why a command was not rundocs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility note — N/A, no storage changesdocs/contract-event-conventions.md, or documented the breaking change and versioning plan — N/A, no event changesCloses Add regression test for governance poll vote weight updating correctly when voter changes their vote #539