Show success toast on buy or sell key transaction#552
Open
Tijesunimi004 wants to merge 1 commit into
Open
Conversation
Trade confirmation now shows "Bought/Sold {n} key(s) from {creator}"
instead of a generic holdings-refreshed message. The quick-buy demo
flow in CreatorCard uses the same wording for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a buy or sell trade confirms, the trade confirmation toast now reads "Bought {n} key{s} from {creator}" or "Sold {n} key{s} from {creator}" instead of a generic "Holdings refreshed" message. The quick-buy demo flow in CreatorCard uses the same wording for consistency.
Toast auto-dismiss (4s) was already in place in
toast.util.tsxand did not need changes.Closes #540
Changes
LandingPage.tsx:handleConfirmTradebuilds the toast message with quantity and creator name for both buy and sell.CreatorCard.tsx: quick-buy success toast message updated to match the same wording.LandingPage.tradeConfirmToast.integration.test.tsxcovering both buy and sell confirmation toasts.Test plan
pnpm vitest run src/pages/__tests__/LandingPage.tradeConfirmToast.integration.test.tsxpassespnpm lintclean (no new errors)pnpm tsc -bclean