Add isOwnWallet utility function with unit tests#543
Merged
Chucks1093 merged 1 commit intoJul 23, 2026
Conversation
- Add isOwnWallet(address, connectedAddress) to walletConnection.utils.ts - Returns false when connectedAddress is null (wallet not connected) - Performs case-insensitive comparison for address matching - Add comprehensive unit tests covering all acceptance criteria: - Matching addresses return true - Non-matching addresses return false - Null connected address returns false - Case-insensitive comparison works correctly
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a shared utility function isOwnWallet to consistently check whether a target address belongs to the connected wallet across UI interactions.
Implementation:
Added isOwnWallet(address: string, connectedAddress: string | null): boolean to walletConnection.utils.ts
Returns false when wallet is not connected (connectedAddress is null)
Performs case-insensitive address comparison to handle different casing formats
Simple, reusable helper for ownership checks (edit controls, sell buttons, etc.)
Testing:
Created comprehensive unit tests in walletConnection.utils.test.ts
6 tests covering all acceptance criteria:
Matching addresses return true
Non-matching addresses return false
Null connected address returns false
Case-insensitive comparison (uppercase vs lowercase)
Mixed casing scenarios
All tests passing
Code Quality:
Formatted with Prettier
ESLint compliant
Follows existing codebase patterns
Ready for code review
closes #530