fix: accept string Responses content and prepare v0.3.1 - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input[].contentvalues instead of rejecting the request as malformed.function_call_output.output[]image blocks.Root cause
The Responses image walker assumed every non-null
input[].contentvalue was an array. Standard Responses requests may use a string shorthand, so valid text-only requests were incorrectly terminated with HTTP 400 before reaching the upstream provider.User impact
String-form Responses input now passes through unchanged. When a string-bearing item also includes a rich function output, image discovery and rewriting still run.
Validation
go test -count=1 ./...go test -race -count=1 ./...go vet ./...go build ./..../scripts/verify-contracts.sh./scripts/package-smoke.shmake verify-version-overrideRelease notes
PR CI validates the Linux amd64 package artifact. The full Linux/macOS/Windows amd64/arm64 matrix remains part of the Release workflow. The billable live-provider test was not run.
Fixes #8