Release 1.1.14: tablet remote vaults + Immersive Mode (#42) - #44
Merged
Conversation
Settings → Vault → Location only mounted the vault quick-switch island in the phone layout, and every app-core remote-workspace entry point is gated on runtime === 'desktop' — so a tablet (desktop layout, like the Galaxy Tab S9 FE report) had no path to Add Remote Vault… at all. Port of the iPhone shell's iPad fix (zennotesios 1ed7787): vaultSettingsAccessForLayout() keeps the full quick-switch on phones and mounts a compact Manage… button on tablets, opening the same canonical Vaults manager; display: contents keeps the button a flex peer of the row's own Change… button. Verified on a Pixel Tablet AVD (API 35) against a self-hosted ZenNotes server: connect with auth token, note read/edit round-trip, boot-time reconnect, Return to Local Vault, and the phone layout unchanged.
The Status bar card becomes System bars with three choices: Shown, No
status bar (the 1.1.12 behavior, same stored value), and Immersive,
which hides the navigation bar too so notes get the entire screen. The
navigation bar goes through core's SystemBars plugin — the StatusBar
plugin has no reach into it — while the status bar keeps its shipped
path; both drive the same WindowInsetsController. MainActivity's
transient-by-swipe behavior already covers all system bars, so a swipe
from a hidden bar's edge peeks it and it slides away on its own, and
with targetSdk 36 the app is edge-to-edge with insets re-applied on
every change, so hidden bars leave no solid background strips.
The preference rides the existing zn:hide-status-bar key ('1' keeps
meaning hidden status bar, 'immersive' is new), so the native mirror in
bootstrap.ts is untouched and an upgrade or downgrade degrades to the
closest older behavior.
Verified on the API 35 emulator with 3-button navigation: all three
modes, transient reveal and auto-hide, cold-start persistence, and the
legacy stored-value mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.1.14 (versionCode 16)
1ed7787). Settings → Vault gains a compact Manage… entry point in the tablet layout, opening the canonical Vaults manager where Add Remote Vault… lives. Verified end-to-end on a Pixel Tablet AVD against a self-hosted server (connect, edit round-trip, boot reconnect, return to local; phone layout unchanged).zn:hide-status-barkey so 1.1.12+ users keep their setting. Verified on API 35 with both 3-button and gesture nav, plus keyboard docking and cold-start persistence.Typecheck clean, 35/35 unit tests, signed
bundleReleaseAAB verified.