Skip to content

scripts: πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in download.pl - #260

Merged
ManupaKDU merged 1 commit into
mainfrom
sentinel-download-injection-6409084823229499627
Aug 14, 2026
Merged

scripts: πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in download.pl#260
ManupaKDU merged 1 commit into
mainfrom
sentinel-download-injection-6409084823229499627

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection and option injection vulnerabilities exist in scripts/download.pl. Unsanitized $url variables are directly interpolated into shell commands. Option injection exists via cat $sq_rfn_path which could be treated as flags by cat if the filename starts with a hyphen.
🎯 Impact: Attackers could execute arbitrary shell commands if they control the download URL.
πŸ”§ Fix: Used shell_quote() to sanitize the $url parameter passed to aria2c and fallback shell commands. Replaced cat $sq_rfn_path with input redirection cat < $sq_rfn_path to prevent option injection. Also removed the duplicate shell_quote subroutine declaration.
βœ… Verification: Ran perl -c scripts/download.pl to verify syntax and make help to ensure build system integration is unbroken.


PR created automatically by Jules for task 6409084823229499627 started by @manupawickramasinghe

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection and option injection vulnerabilities exist in `scripts/download.pl`. Unsanitized `$url` variables are directly interpolated into shell commands. Option injection exists via `cat $sq_rfn_path` which could be treated as flags by `cat` if the filename starts with a hyphen.
🎯 Impact: Attackers could execute arbitrary shell commands if they control the download URL.
πŸ”§ Fix: Used `shell_quote()` to sanitize the `$url` parameter passed to `aria2c` and fallback shell commands. Replaced `cat $sq_rfn_path` with input redirection `cat < $sq_rfn_path` to prevent option injection. Also removed the duplicate `shell_quote` subroutine declaration.
βœ… Verification: Ran `perl -c scripts/download.pl` to verify syntax and `make help` to ensure build system integration is unbroken.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit 7123dfc into main Aug 14, 2026
3 checks passed
@ManupaKDU
ManupaKDU deleted the sentinel-download-injection-6409084823229499627 branch August 14, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant