scripts: π‘οΈ Sentinel: [CRITICAL] Fix command injection in download.pl - #260
Conversation
π¨ Severity: CRITICAL π‘ Vulnerability: Command injection and option injection vulnerabilities exist in `scripts/download.pl`. Unsanitized `$url` variables are directly interpolated into shell commands. Option injection exists via `cat $sq_rfn_path` which could be treated as flags by `cat` if the filename starts with a hyphen. π― Impact: Attackers could execute arbitrary shell commands if they control the download URL. π§ Fix: Used `shell_quote()` to sanitize the `$url` parameter passed to `aria2c` and fallback shell commands. Replaced `cat $sq_rfn_path` with input redirection `cat < $sq_rfn_path` to prevent option injection. Also removed the duplicate `shell_quote` subroutine declaration. β Verification: Ran `perl -c scripts/download.pl` to verify syntax and `make help` to ensure build system integration is unbroken. Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection and option injection vulnerabilities exist in
scripts/download.pl. Unsanitized$urlvariables are directly interpolated into shell commands. Option injection exists viacat $sq_rfn_pathwhich could be treated as flags bycatif the filename starts with a hyphen.π― Impact: Attackers could execute arbitrary shell commands if they control the download URL.
π§ Fix: Used
shell_quote()to sanitize the$urlparameter passed toaria2cand fallback shell commands. Replacedcat $sq_rfn_pathwith input redirectioncat < $sq_rfn_pathto prevent option injection. Also removed the duplicateshell_quotesubroutine declaration.β Verification: Ran
perl -c scripts/download.plto verify syntax andmake helpto ensure build system integration is unbroken.PR created automatically by Jules for task 6409084823229499627 started by @manupawickramasinghe