fix(web): add accessible title to CommandDialog - #206
Conversation
Adds a screen-reader only `DialogTitle` to the `CommandDialog` in `src/components/ui/command.tsx` to resolve Radix UI's accessibility warning regarding missing `DialogTitle` components within `DialogContent`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
Adds a screen-reader only `DialogTitle` to the `CommandDialog` in `src/components/ui/command.tsx` to resolve Radix UI's accessibility warning regarding missing `DialogTitle` components within `DialogContent`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Adds a screen-reader only `DialogTitle` to the `CommandDialog` in `src/components/ui/command.tsx` to resolve Radix UI's accessibility warning regarding missing `DialogTitle` components within `DialogContent`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
A Radix UI DialogContent component in the app is missing an accessible title, triggering an error or warning in the logs (
DialogContent requires a DialogTitle). The missing title was isolated to theCommandDialogused globally for navigation and search. By explicitly adding a visually hiddenDialogTitle(using the Tailwind.sr-onlyclass), the component now correctly fulfills the accessibility contract without negatively impacting the UI. Tests are passing correctly.PR created automatically by Jules for task 9075250064556698387 started by @manupawickramasinghe