🧪 Add edge case tests for get_soc_type in rknn_converter - #201
Conversation
Adds a new test class `TestGetSocType` to `test_rknn_converter.py` to cover the `get_soc_type` logic. Ensures coverage for a `FileNotFoundError` edge case, Nvidia devices, and Rockchip device strings being processed properly. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
🎯 What: Added tests for
get_soc_typefunction insidefrigate/util/rknn_converter.pyto properly cover the file reading logic and edge cases where the device tree file does not exist.📊 Coverage: Covered normal execution paths returning
Nonefor Nvidia models, proper parsing for Rockchip devices, and the missing edge case forFileNotFoundError.✨ Result: Improved robustness by testing the error path and providing safety net tests for SoC parsing logic, directly addressing the testing gap requested.
PR created automatically by Jules for task 4240969424086872374 started by @manupawickramasinghe