Skip to content

🧪 Add edge case tests for get_soc_type in rknn_converter - #201

Merged
ManupaKDU merged 1 commit into
devfrom
test-rknn-get-soc-type-4240969424086872374
Aug 14, 2026
Merged

🧪 Add edge case tests for get_soc_type in rknn_converter#201
ManupaKDU merged 1 commit into
devfrom
test-rknn-get-soc-type-4240969424086872374

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: Added tests for get_soc_type function inside frigate/util/rknn_converter.py to properly cover the file reading logic and edge cases where the device tree file does not exist.
📊 Coverage: Covered normal execution paths returning None for Nvidia models, proper parsing for Rockchip devices, and the missing edge case for FileNotFoundError.
Result: Improved robustness by testing the error path and providing safety net tests for SoC parsing logic, directly addressing the testing gap requested.


PR created automatically by Jules for task 4240969424086872374 started by @manupawickramasinghe

Adds a new test class `TestGetSocType` to `test_rknn_converter.py` to cover the `get_soc_type` logic. Ensures coverage for a `FileNotFoundError` edge case, Nvidia devices, and Rockchip device strings being processed properly.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

PR template validation notice

The PR description could not be validated against the pull request template.

Items to review:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please consider updating your PR description to include all required sections from the template.

@ManupaKDU
ManupaKDU merged commit bfe33be into dev Aug 14, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant