π Fix XSS vulnerability in nv-modal - #33
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
π― What: Fixed a Cross-Site Scripting (XSS) vulnerability in
β οΈ Risk: If left unfixed, any external system, component, or user capable of triggering the
nv-modal.tscaused by injecting unescaped user input directly into the.innerHTMLproperty of the modal body.nv-modalevent could pass a malicious payload in thebodyfield. This payload would then be executed within the context of the user's browser, potentially leading to session hijacking, unauthorized actions, or complete compromise of the application context.π‘οΈ Solution: Imported the standard
DOMPurifylibrary and usedDOMPurify.sanitize(this.mBody)to thoroughly clean and neutralize any potentially malicious input before assigning it to the DOM. Also added@types/dompurifyfor typescript type checking.PR created automatically by Jules for task 10182982558503608552 started by @manupawickramasinghe