Skip to content

NOISS: Fix event unregister time diff bug - #973

Open
kjporter wants to merge 2 commits into
mainfrom
bugfix-event-unregister
Open

NOISS: Fix event unregister time diff bug#973
kjporter wants to merge 2 commits into
mainfrom
bugfix-event-unregister

Conversation

@kjporter

Copy link
Copy Markdown
Contributor

This PR will:

  • Fix a bug that was causing the time diff to fail
  • This PR reverses the order of inputs resulting in a proper calculation

@kjporter
kjporter requested a review from a team as a code owner August 12, 2026 02:37
@kjporter kjporter added the bug Something isn't working label Aug 12, 2026

@iccowan iccowan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. QAing...

@iccowan iccowan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This works as described and catches the 24 hour thing on the backend. One suggestion is that we might want to gray out the Delete Registration button for a better UX. We could even add a note on hover to contact the EC within 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants