release: sync master with PyPI Trusted Publishing fix - #15
Merged
Conversation
…arnings Feat/vscode extension inline warnings
publish-pypi tried password auth via secrets.PYPI_API_TOKEN, which was never actually set as a repo secret (v1.1.0 was published manually instead). With password empty, gh-action-pypi-publish fell back to OIDC trusted publishing, which then failed too since the job had no id-token permission. Switch to Trusted Publishing properly: add `permissions: id-token: write` and drop the password input so the action always uses OIDC. No long-lived token to rotate or leak. Requires a one-time trusted publisher registration on pypi.org (project kshield → Publishing → add YTT-Global/kshield, workflow release.yml) before the next tagged release.
…arnings fix: use PyPI Trusted Publishing instead of a repo-secret API token
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/release.yml: switchespublish-pypifrom asecrets.PYPI_API_TOKENpassword (never set) to PyPI Trusted Publishing (OIDC), addingpermissions: id-token: writeand dropping the password input.Why
v1.1.0'spublish-pypijob failed — the workflow tried API-token auth with an empty token, which madegh-action-pypi-publishfall back to OIDC trusted publishing, which then failed too since the job had noid-tokenpermission.v1.1.0was published to PyPI manually viatwineas a workaround. This PR makes the next tagged release publish to PyPI automatically, with no secret to manage. The PyPI project's trusted-publisher registration (ownerYTT-Global, repokshield, workflowrelease.yml) has already been added on pypi.org.Test plan
.github/workflows/release.ymlis valid (CI YAML lint / next workflow run)publish-pypisucceeds without manualtwine upload