fix: correct typo in testaro buttonMenu test - #137
Open
jrpool wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the misspelled ArrowRight key in horizontal buttonMenu navigation.
Changes:
- Corrects
ArrowtRighttoArrowRightin the TypeScript source. - Synchronizes the emitted JavaScript output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
testaro/buttonMenu.ts |
Applies the key correction. A regression fixture/job is still needed to exercise the horizontal branch. |
testaro/buttonMenu.js |
Mirrors the TypeScript correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: jrpool <3364797+jrpool@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct
ArrowtRighttoArrowRight. Resolves issue #111.A validation target and test for the ArrowRight keypress was added by Copilot. However, the existing validations are partly broken because they expect standard instances to have properties such as
tagNamethat they no longer have. That is another bug, which may exist in the tests for multiple rules, and this pull request does not correct it.