fix: timeout stalled plugin updates - #776
Open
Pranjal1423 wants to merge 6 commits into
Open
Conversation
AllTerrainDeveloper
enabled auto-merge (squash)
September 11, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #765
When a plugin update request stalls indefinitely (e.g. server-side hang, network freeze, or unresponsive proxy), the promise never resolves or rejects. Because the plugins app uses a serial update queue (
updateQueue), a hanging promise causes the queue to remain locked forever, leaving the plugin row permanently in a busy state and preventing any subsequent updates (both single and bulk) from running.This PR adds an execution timeout (
DEFAULT_TIMEOUT_MS = 60_000) to queued update operations viaPromise.race(). If an update promise fails to resolve within the timeout period, it is rejected with anUpdate timeouterror. This allows the existingtry/catch/finallyerror handling inrunUpdate()andrunBulkUpdate()to catch the error, show a failure notice, release the busy state on the row, and allow subsequent queued updates to proceed.Changes
apps/plugins/parts/update-queue.ts: Wrapped the task invocation indrain()withPromise.race()against a configurable timeout timer (defaulting to 60s), ensuring the timeout timer is always cleaned up on completion.tests/vitest/plugins-update-queue.test.ts: Added comprehensive unit test coverage verifying:How to test
npm run test:js tests/vitest/plugins-update-queue.test.tsBefore the Fix
After the Fix