Skip to content

Remove the loading of the SDK overlay class - #946

Merged
dkotter merged 3 commits into
WordPress:developfrom
dkotter:remove/embedding-loading
Aug 17, 2026
Merged

Remove the loading of the SDK overlay class#946
dkotter merged 3 commits into
WordPress:developfrom
dkotter:remove/embedding-loading

Conversation

@dkotter

@dkotter dkotter commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What?

Temporarily removes the loading of the new SDK_Overlay class

Why?

In #892 we brought over the latest version of the PHP AI Client into our plugin inside a custom includes/Vendor directory. This was so we could start using the new embedding support prior to that being released within WordPress core.

We recently decided there are some changes we'd like to see with this embedding integration on the PHP AI Client side and those are being handled upstream in a PR. Once those changes land, we'll pull those in to the AI plugin but in the meantime, this PR disables the loading of the vendored PHP AI Client as we know there will be some breaking changes coming and we'd prefer to not have people start building on code that we know will break.

How?

  • Leaves the vendored code and our helper functions but comments out the loading of the SDK_Overlay class, which is what takes care of loading our vendored code on top of the PHP AI Client that ships with WordPress
  • We do leave the helper functions in place but if anyone tries to use those, will return a WP_Error with the error message Error generating embeddings: Embedding generation is not available in this environment. This function could always return a WP_Error so anyone building on this should already be handling that case
  • Skips a few failing tests that rely on that code being loaded

All of these changes will be reverted once the upstream PR is merged and brought back over here

Use of AI Tools

None

Testing Instructions

Nothing really needs testing other than ensuring base functionality works still in the plugin

Changelog Entry

None needed. We'll want to ensure we don't include the changelog entry from #892 in this release though

Open WordPress Playground Preview

…ed version of the PHP AI Client is not loaded
…be brought back once we bring in the latest PHP AI Client changes
@dkotter dkotter added this to the 1.3.0 milestone Aug 17, 2026
@dkotter dkotter self-assigned this Aug 17, 2026
@dkotter
dkotter requested a review from a team August 17, 2026 17:27
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dkotter dkotter mentioned this pull request Aug 17, 2026
48 tasks
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.86%. Comparing base (a0f5ea2) to head (29c2ea0).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #946      +/-   ##
=============================================
- Coverage      76.01%   73.86%   -2.16%     
  Complexity      3032     3032              
=============================================
  Files            132      132              
  Lines          12001    12004       +3     
=============================================
- Hits            9123     8867     -256     
- Misses          2878     3137     +259     
Flag Coverage Δ
unit 73.86% <ø> (-2.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkotter
dkotter requested a review from jeffpaul August 17, 2026 18:02
@dkotter
dkotter merged commit e05758f into WordPress:develop Aug 17, 2026
28 checks passed
@dkotter
dkotter deleted the remove/embedding-loading branch August 17, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants