Remove the loading of the SDK overlay class - #946
Conversation
…ed version of the PHP AI Client is not loaded
…be brought back once we bring in the latest PHP AI Client changes
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #946 +/- ##
=============================================
- Coverage 76.01% 73.86% -2.16%
Complexity 3032 3032
=============================================
Files 132 132
Lines 12001 12004 +3
=============================================
- Hits 9123 8867 -256
- Misses 2878 3137 +259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What?
Temporarily removes the loading of the new
SDK_OverlayclassWhy?
In #892 we brought over the latest version of the PHP AI Client into our plugin inside a custom
includes/Vendordirectory. This was so we could start using the new embedding support prior to that being released within WordPress core.We recently decided there are some changes we'd like to see with this embedding integration on the PHP AI Client side and those are being handled upstream in a PR. Once those changes land, we'll pull those in to the AI plugin but in the meantime, this PR disables the loading of the vendored PHP AI Client as we know there will be some breaking changes coming and we'd prefer to not have people start building on code that we know will break.
How?
SDK_Overlayclass, which is what takes care of loading our vendored code on top of the PHP AI Client that ships with WordPressWP_Errorwith the error messageError generating embeddings: Embedding generation is not available in this environment. This function could always return aWP_Errorso anyone building on this should already be handling that caseAll of these changes will be reverted once the upstream PR is merged and brought back over here
Use of AI Tools
None
Testing Instructions
Nothing really needs testing other than ensuring base functionality works still in the plugin
Changelog Entry
None needed. We'll want to ensure we don't include the changelog entry from #892 in this release though