Skip to content

Skip the SNI test until it can verify SNI again #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Aug 31, 2026
Merged

Skip the SNI test until it can verify SNI again #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/Transport/BaseTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,13 +906,23 @@ public function testAlternateNameSupport() {
* humanmade.com (owned by Human Made and used with permission) points to
* CloudFront, and will fail if SNI isn't sent.
*
* {@internal Skipped for the time being. The above no longer holds: the host serves the
* same certificate whether SNI is sent or not, so a transport which stopped sending it
* would still pass, and the host has meanwhile started refusing requests outright.
* See https://github.com/WordPress/Requests/issues/1077.}
*
* @dataProvider dataSNISupport
*
* @param array $options Additional options to pass.
*
* @return void
*/
public function testSNISupport($options) {
$this->markTestSkipped(
'This test does not verify SNI support anymore.'
. ' See https://github.com/WordPress/Requests/issues/1077'
);

if ($this->skip_https) {
$this->markTestSkipped('SSL support is not available.');
return;
Expand Down