cleanup: MultithreadedEntityTracker extends AsyncEntityTracker

[kalibrieren]

No description provided.

[windcolor-dev]

MultithreadedEntityTracker is different from AsyncEntityTracker -

The first one uses multiple threads, but waits for all the threads to finish up before moving on. AsyncEntityTracker doesn't wait for all the threads to finish until later on when the next tick starts. It's a really risky change, which is why its completely disabled right now. (See WorldTicker.java and WorldTickManager.java)

Probably best to remove AsyncEntityTracker entirely.

[kalibrieren]

MultithreadedEntityTracker is different from AsyncEntityTracker -

The first one uses multiple threads, but waits for all the threads to finish up before moving on. AsyncEntityTracker doesn't wait for all the threads to finish until later on when the next tick starts. It's a really risky change, which is why its completely disabled right now. (See WorldTicker.java and WorldTickManager.java)

Probably best to remove AsyncEntityTracker entirely.

MultithreadedEntityTracker is basically the same as AsyncEntityTracker with the only difference being that we do latch stuff and send queued packets?

[windcolor-dev]

Oh wait, you're correct in that lots the logic is the same and can be shared.

But heads up, AsyncEntityTracker might get removed because of concurrency risks. So probably best not to extend it.

[kalibrieren]

Oh wait, you're correct in that lots the logic is the same and can be shared.

But heads up, AsyncEntityTracker might get removed because of concurrency risks. So probably best not to extend it.

Think it's best to merge MultithreadedEntityTracker & AsyncEntityTracker into one AsyncEntityTracker keeping flushing etc? Can open a PR. Lmk

[windcolor-dev]

Oh wait, you're correct in that lots the logic is the same and can be shared.
But heads up, AsyncEntityTracker might get removed because of concurrency risks. So probably best not to extend it.

Think it's best to merge MultithreadedEntityTracker & AsyncEntityTracker into one AsyncEntityTracker keeping flushing etc? Can open a PR. Lmk

Yep, how about keeping MultithreadedEntityTracker and then removing AsyncEntityTracker. That would be great!

[kalibrieren]

Oh wait, you're correct in that lots the logic is the same and can be shared.
But heads up, AsyncEntityTracker might get removed because of concurrency risks. So probably best not to extend it.

Think it's best to merge MultithreadedEntityTracker & AsyncEntityTracker into one AsyncEntityTracker keeping flushing etc? Can open a PR. Lmk

Yep, how about keeping MultithreadedEntityTracker and then removing AsyncEntityTracker. That would be great!

#139