SLOP-240: fix FILTER quoting in docs and tolerate quoted values - #18
Open
tosfos wants to merge 1 commit into
Open
SLOP-240: fix FILTER quoting in docs and tolerate quoted values#18tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
The README example set FILTER="..." in a list-style compose environment entry, where the double quotes are kept literally in the value. Word-splitting then produced filters starting/ending with quote characters that match no container, so jobs were silently never scheduled for users following the docs. Drop the quotes from the documented example, warn against quoting, and strip a surrounding pair of double quotes defensively in startup.sh/update_cron.sh so existing deployments recover.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 The image based on be372092 commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILTER="label=... label=..."in a list-style compose environment entry; the double quotes are kept literally in the value (verified with `docker compose config`).$FILTERand wrap fragments in single quotes, so users following the docs got filters like'\"label=cron.extra_label=one'that match no container — jobs were silently never scheduled.startup.shandupdate_cron.shso deployments that copied the old example recover automatically.Jira: SLOP-240
Test plan
--filter label=...args (identical to unquoted input)shellcheck --shell=sh+sh -nclean on both scripts