SLOP-239: parse archive period names by format, not underscore count - #17
Open
tosfos wants to merge 1 commit into
Open
SLOP-239: parse archive period names by format, not underscore count#17tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
parse_previous_period_from_archive_name stripped the last _token group, so hour/minute/second periods (2026-08-20_10 etc.) were truncated to day precision. derive_granularity_to_lock then locked at the wrong granularity and every subsequent archiving run bailed out with BREAK before collecting a group, stalling log archiving permanently once finer-grained archives existed. Match the timestamp grammar from the start of the name to separate period from optional task suffix, and teach derive_granularity_to_lock about hour/minute/second previous periods.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 The image based on bb988c6a commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_previous_period_from_archive_namestripped only the last_tokengroup, truncating hour/minute/second period names (2026-08-20_10) to day precision (2026-08-20).derive_granularity_to_lockthen locked at the wrong granularity; every subsequent run hitBREAKbefore collecting any group — log archiving stalled permanently once finer-grained archives existed (reproduced end-to-end).derive_granularity_to_lockhandles hour/minute/second previous periods (previously dead-codedetermine_granularity_to_lockdid this correctly).Jira: SLOP-239
Test plan
derive_granularity_to_lock: prev hour -> minute, prev minute -> second, prev second -> nonegranularity_to_lock: second(was day); hour-archive continuation creates adjacent archives againshellcheck+bash -nclean