SLOP-238: stop archive-cron-logs from looping forever when nothing is archivable - #16
Open
tosfos wants to merge 2 commits into
Open
SLOP-238: stop archive-cron-logs from looping forever when nothing is archivable#16tosfos wants to merge 2 commits into
tosfos wants to merge 2 commits into
Conversation
added 2 commits
August 22, 2026 05:45
… archivable When eligible logs are at or below target_count (including an empty directory), group_logs_by_time never reaches its end-window BREAK and returns an error result; the driver looped on the unchanged state forever, wedging the scheduled archiving job. Detect a pass that produced no file list and exit the loop instead of retrying.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archive-cron-logs.shloops untilgroup_logs_by_timereturnsBREAK, but when eligible logs are at or belowtarget_count(including an empty directory) no BREAK is ever produced and the script spins forever, wedging the scheduled archiving job (the image's own example schedulesarchive-cron-logs 100monthly).timeout 15for 5-file, empty-dir, and exactly-20-files scenarios; repeatedERROR: Unexpected state in group_logs_by_timeoutput.Jira: SLOP-238
Test plan
shellcheck+bash -nclean