Add support for get_computed_label and get _computed_role#1701
Open
pgorszkowski-igalia wants to merge 3 commits into
Open
Add support for get_computed_label and get _computed_role#1701pgorszkowski-igalia wants to merge 3 commits into
pgorszkowski-igalia wants to merge 3 commits into
Conversation
…ommands https://bugs.webkit.org/show_bug.cgi?id=212549 rdar://63774327 Reviewed by Devin Rousso. Add support for getting the accessibility role and label for elements. This change progresses `get_computed_role` and `get_computed_label` subtests when combined with a safaridriver change to enable these commands and test fixes being reviewed in web-platform-tests/wpt#35581. * Source/WebKit/UIProcess/Automation/Automation.json: * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::getComputedRole): (WebKit::WebAutomationSession::getComputedLabel): * Source/WebKit/UIProcess/Automation/WebAutomationSession.h: * Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::WebAutomationSessionProxy::getAccessibilityObjectForNode): (WebKit::WebAutomationSessionProxy::getComputedRole): (WebKit::WebAutomationSessionProxy::getComputedLabel): * Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h: * Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in: Canonical link: https://commits.webkit.org/253732@main
https://bugs.webkit.org/show_bug.cgi?id=246813 Reviewed by Carlos Garcia Campos. Some style check errors expected due https://webkit.org/b/124730 false positives in Function<> usage. Remaining failures were fixed in the upstream test suite itself and will be imported in https://webkit.org/b/246845. * Source/WebDriver/Session.cpp: (WebDriver::Session::isElementEnabled): (WebDriver::Session::getComputedRole): * Source/WebDriver/Session.h: * Source/WebDriver/WebDriverService.cpp: (WebDriver::WebDriverService::getComputedRole): * Source/WebDriver/WebDriverService.h: * WebDriverTests/TestExpectations.json: Canonical link: https://commits.webkit.org/255824@main
https://bugs.webkit.org/show_bug.cgi?id=246814 Reviewed by Carlos Garcia Campos. Tests still marked as xfailure as they need a fix yet to be imported into local copy. Manually applying the fix shows that they should be passing, though. * Source/WebDriver/Session.cpp: (WebDriver::Session::getComputedRole): Refactor to use getComputedRole command. (WebDriver::Session::getComputedLabel): Added * Source/WebDriver/Session.h: * Source/WebDriver/WebDriverService.cpp: (WebDriver::WebDriverService::getComputedLabel): Added * Source/WebDriver/WebDriverService.h: * WebDriverTests/TestExpectations.json: Update referenced bug Canonical link: https://commits.webkit.org/256146@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fc74ed9