fix: prevent stale group credential acceptance blocking issuance - #449
Draft
lenkan wants to merge 4 commits into
Draft
fix: prevent stale group credential acceptance blocking issuance#449lenkan wants to merge 4 commits into
lenkan wants to merge 4 commits into
Conversation
Persist group KEL and TEL progress so credential issuance and revocation can safely resume after interrupted requests.
Ensure a completed credential acceptance cannot block a later group issuance.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 87.76% 87.41% -0.35%
==========================================
Files 26 26
Lines 5826 5992 +166
==========================================
+ Hits 5113 5238 +125
- Misses 713 754 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Isolate credential test servers and expect asynchronous group operation responses.
lenkan
force-pushed
the
feature/credential-guard-upstream
branch
from
July 14, 2026 15:59
e5bfcbd to
4887165
Compare
Exercise persisted group KEL, TEL, and credential completion states in the long-running operation monitor.
Collaborator
Author
Collaborator
|
@lenkan No, but I am in favour of making the APIs idempotent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A stale multisig credential-issuance acceptance could poison a member while another issuance was in flight:
/multisig/issnotification unread.Before this change, step 3 could return HTTP 500 and leave M2 unable to finish or read credential 2. M1 could also remain blocked waiting for M2's contribution.
Related to #213.
Fix
Treat an already-completed group credential acceptance as idempotent by reusing its persisted operation state, without submitting a conflicting KEL or TEL event.