fix: use Windows-safe _ prefix for catalog node folders - #12
Open
singhguri wants to merge 1 commit into
Open
Conversation
The catalog uses ':'-prefixed directories (:llm, :discord, :whatsapp, ...) as naming markers for catalog-link.sh. Colons are illegal in Windows filenames, so cloning this repo on Windows fails at checkout. Rename every ':prefix' folder to '_prefix' and update catalog-link.sh to treat '_' as the prefix marker (bash resolve_name + Python walk_tree). The generated node names are unchanged: catalog/communication/_discord/send/ still resolves to 'discord-send'. Verified on Windows: - clone/checkout now succeeds (0 invalid paths) - bash scripts/catalog-link.sh --copy produces the same node set: 97 Rust, 98 TS, 2 sidecars, 0 stale - catalog-tree.json prefix flags unchanged (discord: isPrefix=True) Fixes WeaveMindAI#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Cloning the repo fails on Windows because catalog node folders use a
:prefix (:llm,:discord,:whatsapp, ...) as naming markers forcatalog-link.sh. Colons are illegal in Windows filenames, so git aborts the checkout. This renames the marker folders to a Windows-safe_prefix and updates the linker accordingly.How
:prefixfolder to_prefix(167 files, pure renames at 100% similarity).scripts/catalog-link.sh: treat_as the prefix marker in both the bashresolve_name()and the Pythonwalk_tree()(catalog-tree.json generation), plus the doc comments.catalog/communication/_discord/send/still resolves todiscord-send.Verified on Windows (git-bash):
bash scripts/catalog-link.sh --copyproduces the same node set as before: 97 Rust, 98 TS, 2 sidecars, 0 stale.catalog-tree.jsonprefix flags unchanged (discordstillisPrefix: True).Linked issue
Closes #7
Type of change