Skip to content

fix(scripting): flush Node output before exit - #1

Open
dawNotPoi wants to merge 1 commit into
VoidenHQ:mainfrom
dawNotPoi:bugfix/flush-node-script-output
Open

fix(scripting): flush Node output before exit#1
dawNotPoi wants to merge 1 commit into
VoidenHQ:mainfrom
dawNotPoi:bugfix/flush-node-script-output

Conversation

@dawNotPoi

Copy link
Copy Markdown

Fixes VoidenHQ/voiden#554

Summary

  • wait for the piped stdout write to finish before the Node wrapper exits
  • use the same flush-safe exit path for successful, timed-out, and failed worker runs
  • add regression coverage for a 4 MiB result and non-zero failure exit codes

Testing

  • npm test
  • npm run build
  • node build-main.mjs
  • node build-runner.mjs

Signed-off-by: weixiaoing <1537476031@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Script execution failed: Failed to parse Node.js output

1 participant