fix(security): remediate npm audit findings (nanoid) - #372
Draft
Vijay431 wants to merge 1 commit into
Draft
Conversation
Pin nanoid to ^3.3.18 via pnpm override to resolve a high-severity indefinite-loop vulnerability (GHSA-2v37-7h3g-55p8) in the transitive dependency pulled in through postcss -> vite -> vitest.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily security audit found one high-severity advisory. This PR remediates it via a pnpm override, with no direct
package.jsonchanges.CVE details
nanoid<3.3.18>=3.3.18pnpm-workspace.yamloverrides(dev-only transitive dependency, pathpostcss > vite > vitest) — not a direct dependency, so nopackage.jsonbump.nanoid@3.3.16→nanoid@3.3.18nanoid: '^3.3.18'— pinned to the3.xline (not the loose>=3.3.18, which pnpm resolves tonanoid@6.0.1, an ESM-only package incompatible withpostcss's declared^3.3.11CJS-era dependency).postcss's owndependencies.nanoidrange (^3.3.11) is satisfied by3.3.18.Version verification (
npm view)npm view nanoid versions --json— confirmed3.3.18exists on the registry.npm view nanoid@3.3.18 version/type main— confirmed3.3.18is real, still CJS-compatible (main: index.cjs), matching the tree's existingnanoid@3.xshape.postcss@8.5.25's own manifest declaresnanoid: ^3.3.11, so3.3.18satisfies its peer/dependency constraint without forcing a major bump.Type of change
Verification
pnpm run lint— 0 errors, 2 pre-existing warnings incodeAnalysisService.ts(unrelated to this change)pnpm run build— succeeds, main bundle 469.23 KBpnpm run test:unit— 124/124 tests passed across 13 filespnpm run test:unit:coverage— not run (out of scope for this audit)pnpm run test:integration— skipped (no display/xvfb available in this environment)Final
pnpm audit --audit-level=lowpnpm run buildoutputpnpm run test:unitoutputScreenshots or recordings
N/A — dependency-only change, no UI impact.
Checklist
CHANGELOG.mdentry under[Unreleased] > Fixed)dist/,out-test/, and compiled.js/.mapfiles.pnpm-workspace.yaml,pnpm-lock.yaml,CHANGELOG.md)Generated by Claude Code