N60 - #859
Open
Chinchuluun1029 wants to merge 5 commits into
Open
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 006862b and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 28.9% (0% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (-0.2% change). View more on Code Climate. |
SamLee514
requested changes
Sep 30, 2021
SamLee514
left a comment
SamLee514
left a comment
Contributor
There was a problem hiding this comment.
Nice work, everything works correctly. Could you just address the linting issues? Causing a build failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P.S. Had to access the 'select' elements with refs, forgive me for I have sinned (to reset to the disabled default value)
On success:
On error:
