ci: replace auto minor tagging with release-please - #1035
Merged
Conversation
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
leonardocarreras
temporarily deployed
to
internal
July 30, 2026 11:23 — with
GitHub Actions
Inactive
leonardocarreras
marked this pull request as ready for review
July 30, 2026 11:30
stv0g
approved these changes
Jul 30, 2026
stv0g
approved these changes
Jul 30, 2026
stv0g
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
tag-minor-releasewith release-please.tag-minor-releasehas never produced a release: it fails withfatal: empty ident name,actions/checkoutsets no git identity. Fixing that alone would make it worse, since it cuts a stable minor on every master merge and derives the version only fromgit tag --list, never fromCMakeLists.txt,python/pyproject.tomlordoc/package.json(all1.1.0today, last tagv1.0.1). It also pushes the tag withGITHUB_TOKEN, whose events start no workflow runs, sopush: tags: ["v*"]would never fire.release-please opens a release PR that bumps all three files and maintains
CHANGELOG.md; merging it is the release decision. In the first releaseCMakeLists.txtanddoc/package.jsonshow no diff, since they already say1.1.0; leonardocarreras#3 is a bump where the numbers do move, and changes all five files. Version follows Conventional Commits, overridable with aRelease-As:footer. The manifest starts at1.0.1, so the first PR reconciles the drift and re-cuts1.1.0.Details:
ci.yamlat the new tag,workflow_dispatchbeing a documented exception to theGITHUB_TOKENrule.is_version_tagis then true anddeploy/release-nixrun. No PAT needed.target-branch: master, so a manual dispatch cannot release unmerged code.CHANGELOG.mdcarries no SPDX header and tripsMD012, so it is annotated inREUSE.tomland excluded from markdownlint rather than weakening either for everything else.Touches
.pre-commit-config.yamlin a different place than #1034, so the two merge cleanly in either order. A follow-up, not here: the release page gives no hint that container images exist, since assets can only hold files.Exercised end to end on my fork with this exact config: merging leonardocarreras#5 tagged and published
v1.1.0, and the CI run it dispatched passed in full, attaching the ARX and RPM bundles to that release and movinglatestandlatest-nix.