Some fixes for species search - #9
Open
chrab wants to merge 3 commits into
Open
Conversation
Search with ions + did not work.
Otherwise the routine did throw some pandas exception and was unclear what happened.
Author
|
Hello Guys, Thanks for developing this useful package. I used the package's species search and found some bugs, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using getSpeciesWithSearchCriteria with text_search and trying to find e.g., HCO+, the routine did not return any results; it just threw some pandas Exception.
The main reason was that the HTTP request parameters were not encoded, so the + was not correctly interpreted.
Also, in case the routine does not find anything (but otherwise things are okay), it now returns None, instead of throwing some pandas Exception.