Close field-free dialogs on outside click by default - #1843
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 46a4546 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 07:20 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 46a4546 | Aug 29 2026, 07:22 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dialog or sheet now decides from its contents whether a click outside closes it. While it holds a form field (inputs, textareas, contenteditable, or ARIA widget controls like select/combobox triggers, checkboxes, switches, radios), an outside click keeps it open, so a stray click cannot discard what the user typed. A surface with no fields closes on outside click.
dismissOnOutsideClickstill overrides the detection in either direction; existing explicit call sites keep their behavior. The portaled combobox/select popup guard is unchanged, and AlertDialog is unaffected.New e2e scenario
dialog-outside-dismisscovers both sides on the API keys page: the create form and the one-time key reveal survive outside clicks, while the field-free revoke confirm dismisses without firing.